Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Fix Travis and Panda tz_localize #679

Closed
wants to merge 4 commits into from
Closed

Fix Travis and Panda tz_localize #679

wants to merge 4 commits into from

Conversation

clslgrnc
Copy link
Contributor

@clslgrnc clslgrnc commented Feb 13, 2019

Travis is still broken.

It should work with the included changes:

@clslgrnc clslgrnc changed the title Fix travis Fix Travis and Panda tz_localize Feb 13, 2019
@clslgrnc
Copy link
Contributor Author

#674 was not sufficient to get Travis back up. Any comment on this one?

@lovasoa
Copy link
Contributor

lovasoa commented Feb 25, 2019

@aviau any feedback on whether this can be merged ?

@clslgrnc
Copy link
Contributor Author

@aviau @xginn8 @sebito91 any comment on this one?

I want to say I really appreciate being able to interact with influxdb from python and understand you are volunteers and are also involved in other projects (I read the README, I am not taking offense 😉, I hope you won't).

Yet a broken CI is even more discouraging than a lack of response. It pollutes otherwise nice PR like #650, and stalls others like #664 that you deemed ready to merge once CI is back online more than two month ago (CI has been down since last summer).

If you need help do not hesitate to reach out.

@lovasoa
Copy link
Contributor

lovasoa commented Feb 27, 2019

I can help too ! We rely on this library, and can help maintaining it if needed.

@xginn8
Copy link
Collaborator

xginn8 commented Feb 27, 2019

I should be able to take a look today, thanks for contributing!

@lukaszdudek-silvair
Copy link
Contributor

Is there anything that can be done to speed up merging this? It seems to be stalling merging anything else.

@xginn8
Copy link
Collaborator

xginn8 commented Mar 4, 2019

@clslgrnc thank you for contributing, I really appreciate your time and effort here! Can you remove the extra influxdb test case and fix this all in separate PRs? As I understand it, there are three substantive changes combined into this one PR (which will be merged down to a single commit). These should all be different commits, and the tz_localize & officially supporting influxdb 1.7.2 changes should be included in the changelog for posterity.

@clslgrnc
Copy link
Contributor Author

clslgrnc commented Mar 5, 2019

Will do, note that the PRs will not pass CI since all commits are necessary.

@clslgrnc
Copy link
Contributor Author

clslgrnc commented Mar 5, 2019

Done.
I'll add support for more recent versions of python and influxdb once #682, #683, and #684 are merged (I do not want to go blind with a broken CI).

@clslgrnc
Copy link
Contributor Author

Any comment on #682, #683, or #684 ?

@clslgrnc
Copy link
Contributor Author

closing as this is superseded by #682, #683, and #684

@clslgrnc clslgrnc closed this Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas 0.24.0 TypeError TzInfo Pandas 0.23.4 TypeError: Already tz-aware
5 participants