Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

[WIP] add py37 and recent influxdb #692

Merged
merged 8 commits into from
Mar 15, 2019
Merged

[WIP] add py37 and recent influxdb #692

merged 8 commits into from
Mar 15, 2019

Conversation

clslgrnc
Copy link
Contributor

  • diversify panda and numpy version

@clslgrnc clslgrnc changed the title [WIP] add py37 and recent influxdb add py37 and recent influxdb Mar 15, 2019
@clslgrnc clslgrnc marked this pull request as ready for review March 15, 2019 14:14
@clslgrnc clslgrnc changed the title add py37 and recent influxdb [WIP] add py37 and recent influxdb Mar 15, 2019
@clslgrnc
Copy link
Contributor Author

clslgrnc commented Mar 15, 2019

It seems that a test fails with numpy > 1.13.3
I'll investigate later

@clslgrnc
Copy link
Contributor Author

Here is the culprit:

>>> np.version.version
'1.13.3'
>>> a = np.float64('1.1111111111111')
>>> str(a)
'1.11111111111'
>>> np.version.version
'1.16.2'
>>> a = np.float64('1.1111111111111')
>>> str(a)
'1.1111111111111'

@clslgrnc
Copy link
Contributor Author

I really do not know how to put python 3.7 into travis matrix.
An alternative would be to use xenial and sudo:true for all builds. What do you think?

@aviau
Copy link
Collaborator

aviau commented Mar 15, 2019

An alternative would be to use xenial and sudo:true for all builds.

We should avoid doing that. Container builds are scheduled faster (I think) and going back to VMs would be a step backwards. (they may even be discontinued at some point?)

However since you can only enable it for the 3.7 jobs it will do fine for now.

Should someone find a way to do without, I'll gladly merge.

@aviau
Copy link
Collaborator

aviau commented Mar 15, 2019

Thank you for the PR!

@aviau aviau merged commit bf95e0f into influxdata:master Mar 15, 2019
@clslgrnc clslgrnc deleted the supported_versions branch March 16, 2019 07:08
@clslgrnc
Copy link
Contributor Author

This time you were too fast for me 😉 I pushed the doc and a small fix in #693.
(To your defense I was fiddling with the WIP status of the PR, I felt that travis was not starting fast enough)

LloydW93 pushed a commit to bbc/influxdb-python that referenced this pull request Apr 15, 2019
* add py37 and recent influxdb

* remove useless py34 dep

* use py36 for pydocstyle (py27 soon deprecated)

* ugly fix to numpy inconsistencies

* py37 is not in ubuntu 14.04

* move import numpy and add noqa

* get 3.7 into travis matrix

* get 3.7 into travis matrix
tux-00 pushed a commit to tux-00/influxdb-python that referenced this pull request Apr 24, 2019
* add py37 and recent influxdb

* remove useless py34 dep

* use py36 for pydocstyle (py27 soon deprecated)

* ugly fix to numpy inconsistencies

* py37 is not in ubuntu 14.04

* move import numpy and add noqa

* get 3.7 into travis matrix

* get 3.7 into travis matrix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants