This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Fix json decoding on Python 3 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it me or Travis didn't run? Ill merge if Travis passes. |
|
Looks like the build started after I pushed to the branch lol. |
|
@jonashaag It failed in python3 :( |
| # must decode in python 3 | ||
| res = json.loads(response.content.decode('utf8')) | ||
|
|
||
| return res |
There was a problem hiding this comment.
The function used to return a dict ant it now returns a string (json)
You should return json.loads(response.json())
There was a problem hiding this comment.
HTTP body content is expected to be bytes, not unicode.
aviau
added a commit
that referenced
this pull request
Oct 30, 2014
Fix json decoding on Python 3 (thanks @jonashaag)
|
@jonashaag thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36 -- there exists a much easier solution to the approach taken there, that is just relying on the
requestslibrary to decode the json (the Python 2/3 difference is dealt with there already).How can the current implementation even pass the tests on Python 3? The
get_database_listCAN'T possibly work on Python 3 because it wasn't taken care of in #36.