This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Specify Retention Policy in SeriesHelper #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @csanz91 please ensure that all the tests are passing in Travis, and then we can take a look |
|
All tests are passing now. Feel free to review the pull request. |
|
Hi @csanz91 and thanks for submitting this patch! The implementation looks fine, but please add some tests to ensure this feature functions properly. You'll want to look here: https://github.com/influxdata/influxdb-python/blob/master/influxdb/tests/helper_test.py |
xginn8
suggested changes
Sep 16, 2019
|
I have added a couple of tests in which I check the args passed to the "write_points" function to look for the specified retention policy. I also have a case without a retention policy to make sure I'm not altering the default rp. |
sebito91
approved these changes
Apr 10, 2020
ocworld
pushed a commit
to AhnLab-OSS/influxdb-python
that referenced
this pull request
Apr 13, 2020
* Allow specify a retention policy in SeriesHelper * Complete the annotation example with the retention policy * Fix formatting * Fix formatting again * Add helper write with retention policy * Add helper write without retention policy * Remove blank line after the docstring. Co-authored-by: Sebastian Borza <sebito91@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an option in the SeriesHelper meta options to be able to write the data with a custom retention policy.
This request was previously commented in this issue: #300