This repository was archived by the owner on Oct 29, 2024. It is now read-only.
gzip compression for data (post and responses) #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, figured out zlib so that it's compatible with python 2.7. |
xginn8
suggested changes
Sep 9, 2019
per review
|
Interestingly I noticed that the zlib compressed data wasn't actually being added to InfluxDB. Switching back to gzip and manually ensuring that data is posted. |
|
Any chance to see this PR merged? |
sebito91
approved these changes
Apr 10, 2020
ocworld
pushed a commit
to AhnLab-OSS/influxdb-python
that referenced
this pull request
Apr 13, 2020
* gzip compression working in my influx stack. Needs proper tests. * Also gzip data from server, slightly more straightforward data handling. * Adding in test cases. * Switching back to zlib with gzip headers. * flake8 compatibility * Move parameter into correct position. per review * Switching back to gzip for the headers. * Fixing python 2.7 compatability with gzip. * flake8 compatibility. * flake8 testing Co-authored-by: Kevin Claytor <kevin.e.claytor.civ@mail.mil> Co-authored-by: Sebastian Borza <sebito91@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have enabled gzip content encoding in this branch. I have tested it against my own influx application and it seems to work. However, I am unsure how to properly do the tests.
I have included some tests, however, they do not actually track integration with the influxdb application. For instance, the tests pass when I use zlib do do the compression, even though that does not work in my application. Can you advise where / how to do proper implementation tests?
If you would like to incorporate it into the main branch, I would certainly find it useful and others may as well (see: #718).