This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Make batched writing support all iterables #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is now green so I'd appreciate a review 🙏 |
xginn8
reviewed
Sep 9, 2019
influxdb/client.py
Outdated
| @@ -6,14 +6,14 @@ | |||
| from __future__ import print_function | |||
| from __future__ import unicode_literals | |||
|
|
|||
| import itertools | |||
There was a problem hiding this comment.
Rather than importing the whole itertools module, how about just importing what's needed (islice & chain)?
a8b2bdd to
d6e7d1c
Compare
JayH5
commented
Sep 10, 2019
|
@xginn8 done, thanks. |
|
@xginn8 maybe we can get this merged now? |
ocworld
pushed a commit
to AhnLab-OSS/influxdb-python
that referenced
this pull request
Apr 13, 2020
* Make batched writing support all iterables * Also test batching generator against real server * Fix PEP257 error * Import itertools functions directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some data we write to InfluxDB from lazy iterables/generators that don't necessarily support indexing or have a length that can be known up-front.
This is a second attempt at #408. It includes a fix for Python 3.7 compatibility (catches the
StopIteration).