This repository was archived by the owner on Oct 29, 2024. It is now read-only.
do not sleep after last retry before raising exception #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retry=0 - retry forever retry=1 - try once, on error don't do any retry retry=2 - 2 tries, one original and one retry on error retry=3 - 3 tries, one original and maximum two retries on errors
sebito91
suggested changes
Apr 10, 2020
There was a problem hiding this comment.
Thanks for the PR @krzysbaranski, appreciate you taking the time to help out! Could you please look to address the feedback and resubmit when you get a chance?
influxdb/client.py
Outdated
| @@ -292,7 +295,7 @@ def request(self, url, method='GET', params=None, data=None, | |||
| _try += 1 | |||
| if self._retries != 0: | |||
| retry = _try < self._retries | |||
| if method == "POST": | |||
| if retry and method == "POST": | |||
There was a problem hiding this comment.
I would just invert the logic here:
if self._retries != 0:
retry = _try < self._retries
if not retry:
raise
if method == "POST":
...
influxdb/client.py
Outdated
| defaults to 3. 0 indicates try until success | ||
| For example: | ||
| 1 - try only once (without retry), | ||
| 2 - maximum two tries (including one retry) |
There was a problem hiding this comment.
Can you please also add a line here for the default option?
:param retries: number of attempts your client will make before aborting, defaults to 3
0 - try until success
1 - attempt only once (without retry)
2 - maximum two attempts (including one retry)
3 - maximum three attempts (default option)
sebito91
approved these changes
Apr 11, 2020
ocworld
pushed a commit
to AhnLab-OSS/influxdb-python
that referenced
this pull request
Apr 13, 2020
* do not sleep after last retry before raising exception * documentation: clarification of retry parameter retry=0 - retry forever retry=1 - try once, on error don't do any retry retry=2 - 2 tries, one original and one retry on error retry=3 - 3 tries, one original and maximum two retries on errors * retries - move raise before sleep * retries - documentation * fix line length
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not sleep after last retry before raising exception
documentation: clarification of how retry parameter works
retry=0 - retry forever
retry=1 - try once, on error don't do any retry
retry=2 - 2 tries, one original and one retry on error
retry=3 - 3 tries, one original and maximum two retries on errors