Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Fix #828 "Context manager for InfluxDBClient not working correctly?" #831

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

antimirov
Copy link
Contributor

@antimirov antimirov commented Jun 15, 2020

Fixed it by returning a client instance from __ enter __


Contributor checklist
  • Builds are passing
  • [] New tests have been added (for feature additions)

…rrectly?" by returning a clientt instance from __enter__
@antimirov
Copy link
Contributor Author

Hm, the CI error seems to be unrelated to the commit. Can it be triggered to re-run?

@vancromy
Copy link

vancromy commented Dec 3, 2020

@aviau @sebito91 Would it be possible to review this. Doesn't look like a harmful change and as is although the documentation boasts the feature of context managers it is not right. As is today the client does not work as a context manager... Either fix the code or change the documentation :)

@Ramshield
Copy link

@aviau @sebito91 Anything I can do to help?

@russorat
Copy link
Contributor

russorat commented Apr 8, 2021

@antimirov just sign the CLA form and I will merge this. https://www.influxdata.com/legal/cla/#license-agreement

@antimirov
Copy link
Contributor Author

@russorat I've signed it, please proceed

Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russorat russorat merged commit 6d90ef7 into influxdata:master Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants