This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Add time_precision option to datetime_to_epoch. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. We could add a test maybe? @timtroendle Can you take a look at this please? |
|
@tzonghao The tests look good. Thank you for the quality PR :) |
|
@ReAzem No problem. DataFrame support is very nice to have. Glad to help. |
|
Yes, looks good to me. Nice! |
aviau
added a commit
that referenced
this pull request
Dec 11, 2014
Add time_precision option to datetime_to_epoch. (Thanks @tzonghao)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
time_precision"m" or "u" was passed towrite_points,_datetime_to_epochneeds to translate timestamps into milliseconds or microseconds accordingly.