Fixing UsersClient.View when searching with parameters #153
+14
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
/user?param=parameters enpoint returns a list of users, not a single user.
Because of this UsersClient.View is broken and always returns an object with all null values unless you search by id because /users/{id} is the endpoint that returns a single user.
How?
When querying by params (ie by user_id={user_id} or email={email}) return {resultObject}.users.FirstOrDefault() instead of {resultObject}
Investigate
I could only test this for the /users/email={email} endpoint, as our user_ids are empty, but I am assuming they work the same way.
Is /users/email={email} supposed to only return a single user? Is THAT the issue here? Or was that updated and the docs/packages werent?
https://developers.intercom.com/intercom-api-reference/reference#view-a-user