Fix double initialization of user authentication in ScriptTag #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72ca065 to
c49e926
Compare
DamonFstr
commented
Dec 19, 2024
Comment on lines
-28
to
-29
| s.add_development_dependency 'thin', '~> 1.7.0' | ||
| s.add_development_dependency 'bigdecimal', '1.3.5' |
There was a problem hiding this comment.
Not needed? I couldn't install these on apple silicon/newer ruby. I was going to bump them but removing them appears to have done nothing.
I think big decimal might be included in modern versions of ruby?
There was a problem hiding this comment.
Look like 1.3.5 version is for ruby version before 2.5 if you want to use BigDecimal.new and subclassing without warning, see here
But I'm not sure if we actually need it in our gem.
c49e926 to
e6410ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing ScriptTag, we were calling user_details= twice:
once for initial user details and again when merging lead attributes.
In #356, this caused both JWT and user_hash to be included in the settings
when only one should be present (because we delete the user_id from the unsigned payload - so we end up doing user_hash on the email address the 2nd time around)