Skip to content

[feature] Conversation : Add/remove nested resource 'contact' #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2020
Merged

[feature] Conversation : Add/remove nested resource 'contact' #517

merged 3 commits into from
Mar 10, 2020

Conversation

WaKeMaTTa
Copy link
Contributor

@WaKeMaTTa WaKeMaTTa commented Mar 6, 2020 •
edited
Loading

Implemented add_contact and remove_contact actions in Conversation.

# Add a contact to a conversation
conversation.add_contact(admin_id: admin.id, customer: { intercom_user_id: contact.id })

# Remove a contact from a conversation
conversation.remove_tag(id: contact.id, admin_id: admin.id)

Fixes #515

@WaKeMaTTa WaKeMaTTa marked this pull request as ready for review March 6, 2020 17:22
@WaKeMaTTa WaKeMaTTa force-pushed the conversation-add-remove-nested-contact branch from 792367b to 066ddc7 Compare March 6, 2020 17:22
@WaKeMaTTa WaKeMaTTa force-pushed the conversation-add-remove-nested-contact branch from 066ddc7 to 3035aa7 Compare March 6, 2020 17:23
murtron
murtron reviewed Mar 9, 2020
View reviewed changes
@murtron
Copy link
Contributor

murtron commented Mar 9, 2020

Nice one @WaKeMaTTa, this is great! Just one minor README change and I'll include this in the next release.

@WaKeMaTTa @murtron
[typo] README - Fix typo
0be174a 
Co-Authored-By: Matthew Murray <matthew.murray@intercom.io>
@WaKeMaTTa WaKeMaTTa requested a review from murtron March 9, 2020 12:04
@murtron murtron merged commit dffd960 into intercom:master Mar 10, 2020
@murtron murtron mentioned this pull request Mar 10, 2020
Merged
@WaKeMaTTa WaKeMaTTa deleted the conversation-add-remove-nested-contact branch March 10, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murtron murtron murtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to attach / add a contact to a conversation ?
2 participants
@WaKeMaTTa @murtron