Added dirty_tracking support for nested objects #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulgdsouza
commented
Jun 2, 2020
| @@ -97,7 +112,7 @@ | |||
| it 'an initialized ApiResource is equal to one generated from a response' do | |||
| class ConcreteApiResource; include Intercom::Traits::ApiResource; end | |||
| initialized_api_resource = ConcreteApiResource.new(object_json) | |||
| except(object_json, 'type').keys.each do |attribute| | |||
| except(object_json, 'type', 'nested_fields').keys.each do |attribute| | |||
There was a problem hiding this comment.
Temporarily added.
- The test checks for equality, The typed objects currently have no definition for equality.
There was a problem hiding this comment.
Equality for lightweight classes will be addressed in a separate PR.
rahulgdsouza
commented
Jun 2, 2020
| @@ -107,12 +122,28 @@ class ConcreteApiResource; include Intercom::Traits::ApiResource; end | |||
|
|
|||
| api_resource.from_hash(object_hash) | |||
| initialized_api_resource = ConcreteApiResource.new(object_hash) | |||
|
|
|||
| except(object_json, 'type').keys.each do |attribute| | |||
| except(object_json, 'type', 'nested_fields').keys.each do |attribute| | |||
There was a problem hiding this comment.
Temporarily added.
- Typed objects are created only when the hash has a key
typeas string. Symbol is not taken into account.
Even though this test passes. It should've ideally failed like the previous one.
Added nested_fields here just to maintain consistency.
There was a problem hiding this comment.
Will be addressed in a separate PR, Possible solutions
- Manual check of type as string/symbol
- Hash.symbolize_keys
- Hash.with_indifferent_access
rahulgdsouza
added a commit
that referenced
this pull request
Jul 14, 2020
* Articles endpoint SDK support * Collections Endpoint Support (#523) * Sections Endpoint Support (#524) * Added Collections endpoint SDK support * Added test coverage * Added dirty_tracking support for nested objects (#525) * Added support to check for equality of two resources (#527) * Updated README and logged changes for v4.1.0 (#526)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
SDK currently does not support,