Skip to content

Allow companies to be deleted #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2020
Merged

Allow companies to be deleted #552

merged 4 commits into from
Oct 29, 2020

Conversation

ClaytonPassmore
Copy link
Contributor

Why?

Intercom has supported deleting companies since API v2.0. My app needs to be able to delete company information from Intercom and this would simplify my life! 🙏

How?

I leveraged the existing delete API operation and simply added it to the company service. Now you can call:

client.companies.delete(company)

rahulgdsouza
rahulgdsouza reviewed Oct 29, 2020
View reviewed changes
@rahulgdsouza
Copy link
Contributor

Looks good to me 👍 Minor comment on the spec.

@ClaytonPassmore
Copy link
Contributor Author

Thanks for the suggestion @rahulgdsouza! 🙏 Updated!

rahulgdsouza
rahulgdsouza approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@rahulgdsouza rahulgdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rahulgdsouza rahulgdsouza merged commit de8ca33 into intercom:master Oct 29, 2020
@ClaytonPassmore ClaytonPassmore deleted the feature/company-delete branch October 29, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulgdsouza rahulgdsouza rahulgdsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClaytonPassmore @rahulgdsouza