Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
Changelog
=========

* 2.0.beta (not yet released)
* fixed `UnboundLocalError` in `Request.parse_body`.
* added support for replies with an empty body.
* 2.0.alpha
* support for Intercom API v2
* support for Python 3
Expand Down
3 changes: 2 additions & 1 deletion intercom/api_operations/save.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ def create(cls, **params):
from intercom import Intercom
collection = utils.resource_class_to_collection_name(cls)
response = Intercom.post("/%s/" % (collection), **params)
return cls(**response)
if response: # may be empty if we received a 202
return cls(**response)

def from_dict(self, pdict):
for key, value in list(pdict.items()):
Expand Down
11 changes: 7 additions & 4 deletions intercom/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,15 @@ def send_request_to_path(cls, method, url, auth, params=None):
@classmethod
def parse_body(cls, resp):
try:
body = json.loads(resp.content.decode())
decoded_body = resp.content.decode()
if not decoded_body: # return early for empty responses (issue-72)
return
body = json.loads(decoded_body)
if body.get('type') == 'error.list':
cls.raise_application_errors_on_failure(body, resp.status_code)
return body
except ValueError:
cls.raise_errors_on_failure(resp)
if body.get('type') == 'error.list':
cls.raise_application_errors_on_failure(body, resp.status_code)
return body

@classmethod
def set_rate_limit_details(cls, resp):
Expand Down
1 change: 1 addition & 0 deletions tests/integration/issues/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# -*- coding: utf-8 -*-
25 changes: 25 additions & 0 deletions tests/integration/issues/test_72.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# -*- coding: utf-8 -*-

import os
import unittest
import time
from intercom import Intercom
from intercom import Event
from intercom import User

Intercom.app_id = os.environ.get('INTERCOM_APP_ID')
Intercom.app_api_key = os.environ.get('INTERCOM_APP_API_KEY')


class Issue72Test(unittest.TestCase):

def test(self):
User.create(email='me@example.com')
# no exception here as empty response expected
data = {
'event_name': 'Eventful 1',
'created_at': int(time.time()),
'email': 'me@example.com'
}
print data
Event.create(**data)
28 changes: 8 additions & 20 deletions tests/unit/test_event.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,16 @@
# -*- coding: utf-8 -*-

import httpretty
import json
import re
import time
import unittest

from datetime import datetime
from intercom import User
from intercom import Intercom
from intercom import Event
from nose.tools import eq_
from nose.tools import ok_
from mock import patch
from nose.tools import istest

post = httpretty.POST
r = re.compile


class EventTest(unittest.TestCase):

Expand All @@ -29,7 +24,6 @@ def setUp(self): # noqa
self.created_time = now - 300

@istest
@httpretty.activate
def it_creates_an_event_with_metadata(self):
data = {
'event_name': 'Eventful 1',
Expand All @@ -41,13 +35,10 @@ def it_creates_an_event_with_metadata(self):
'found_date': 12909364407
}
}
httpretty.register_uri(
post, r(r'/events/$'), body=json.dumps(data), status=202)
event = Event.create(**data)

eq_('Eventful 1', event.event_name)
ok_(hasattr(event, 'metadata'))
eq_('pi@example.com', event.metadata['invitee_email'])
with patch.object(Intercom, 'post', return_value=data) as mock_method:
Event.create(**data)
mock_method.assert_called_once_with('/events/', **data)

@istest
@httpretty.activate
Expand All @@ -56,9 +47,6 @@ def it_creates_an_event_without_metadata(self):
'event_name': 'sale of item',
'email': 'joe@example.com',
}
httpretty.register_uri(
post, r(r'/events/$'), body=json.dumps(data), status=202)
event = Event.create(**data)

eq_('sale of item', event.event_name)
ok_(not hasattr(event, 'metadata'))
with patch.object(Intercom, 'post', return_value=data) as mock_method:
Event.create(**data)
mock_method.assert_called_once_with('/events/', **data)