Skip to content

Try testing built wheels #14821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Try testing built wheels #14821

wants to merge 9 commits into from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Mar 5, 2025 •
edited
Loading

elevator pitch

Run CI tests against built distributions.

references

changes

  • add a test.yml#jobs/build, build the package once, and archive distributions
  • in test.yml#jobs/test
    • download the artifacts
    • build up a requirements.txt with a PEP 508 spec for ipython
    • add pip check
    • run tests in test to avoid confusion

future work

  • going to a src/-style layout would fix some of the issues, but still not -e . masking errors about files that aren't packaged due to settings in pyproject.toml

@Carreau
Copy link
Member

Carreau commented Mar 6, 2025

  • going to a src/-style layout would fix some of the issues, but still not -e . due to

I think you did not finish your sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test the built assets
2 participants
@bollwyvl @Carreau