Skip to content

Fix: always clear _draw_called #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Fix: always clear _draw_called #17

merged 1 commit into from
Aug 12, 2022

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Jun 14, 2022

Disclaimer: I'm not hugely up to speed with this logic, so this fix might be ill-posed.

plt.ioff has no effect with the inline backend when InlineBackend.close_figures is set to True. This PR ensures that we always clear the flag after calling flush.

@agoose77 agoose77 changed the title Fix: always clear draw_called Fix: always clear _draw_called Jun 14, 2022
@fperez
Copy link
Member

fperez commented Aug 12, 2022

I hadn't looked at this code in years, but the code itself LGTM, thx @agoose77!

Merging now.

@fperez fperez merged commit 3347d0f into ipython:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants