Skip to content

Don't run dvc-studio.yml on tag push, coz otherwise MR version and st… #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

tapadipti
Copy link
Contributor

…age assignment actions trigger this workflow

…age assignment actions trigger this workflow
@daavoo daavoo merged commit 9931196 into master Aug 21, 2023
@daavoo daavoo deleted the tapadipti-patch-2 branch August 21, 2023 13:10
@dberenbaum
Copy link

Sorry, I think I misunderstood the workflow here. Aren't version and stage updates when the action should be triggered? Like in https://github.com/iterative/example-gto/blob/main/.github/workflows/gto-act-on-tags.yml?

@daavoo
Copy link
Contributor

daavoo commented Aug 21, 2023

Sorry, I think I misunderstood the workflow here. Aren't version and stage updates when the action should be triggered? Like in https://github.com/iterative/example-gto/blob/main/.github/workflows/gto-act-on-tags.yml?

This change is for the workflow that runs an experiment

@tapadipti
Copy link
Contributor Author

Aren't version and stage updates when the action should be triggered?

We could trigger the action on both user actions - version registration and stage assignment - or just on stage assignment.

The convention we are following is that when a user assigns a stage, they intend to deploy the model to that stage. So, we create the endpoint during this user action. This step requires the SageMaker model to have been created.

The SageMaker model itself could be created at one of the following two points:

  • we could create it when a users registers a version, coz they will likely assign a stage for that version, and so it's a good idea to keep the model created and ready.
  • we could create it only after the user assigns a stage, coz until then there's no need to deploy the model, which means that the SageMaker model is not really needed until then.

Accordingly, we could trigger the GH action during version registration and stage assignment, or only during stage assignment.

Does this answer your question @dberenbaum

@tapadipti
Copy link
Contributor Author

Also, I didn't check which PR you had added your question in. So, I guess @daavoo's reply was enough. Anyway, I hope the above explanation doesn't hurt either 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants