Skip to content

Allow importing services from PHP and XML configuration files #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2018

Conversation

ajgarlag
Copy link
Contributor

See #10

@jakzal
Copy link
Owner

jakzal commented Jul 30, 2018

What's the use case? Especially for php based config? :)

@ajgarlag
Copy link
Contributor Author

I have a new project where I've setup the services using the fluent PHP based configuration introduced in symfony/symfony#23834.

With this format the IDE provides better code completion suggestions and I can rename classnames declared in configuration files using the Refactor feature included in the IDE.

I've added support for XML format after seeing #10

@jakzal
Copy link
Owner

jakzal commented Jul 30, 2018

Thank you for your contribution!

With this format the IDE provides better code completion suggestions and I can rename classnames declared in configuration files using the Refactor feature included in the IDE

This depends on the IDE. Phpstorm with the Symfony plugin does a really good job for me.

With auto wiring support and minimal amount of config you need to add, I don't see a point of using php or xml. Especially in a behat extension. Nevertheless, I can understand to some it's appealing and I'm probably gonna merge this in ;)

@jakzal jakzal merged commit b7c0608 into jakzal:master Jul 31, 2018
@jakzal
Copy link
Owner

jakzal commented Jul 31, 2018

Thank you @ajgarlag!

@jakzal
Copy link
Owner

jakzal commented Jul 31, 2018

Included in the v2.1.0 release.

@ajgarlag
Copy link
Contributor Author

Thank you @jakzal for merge and quick release.

There is an error in the release note:

Ignore development files from git export (#16) / thanks @ajgarlag

@jakzal
Copy link
Owner

jakzal commented Jul 31, 2018

@ajgarlag copy&paste is the source of all evil :P fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants