http response: ensuring that the repeated response header is merged i…

…nto a concatenated string, instead of an array, refs #48
janreges · Jan 22, 2025 · c0f3b21 · c0f3b21
1 parent c8f2ffc
commit c0f3b21
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/Crawler/HttpClient/HttpResponse.php b/src/Crawler/HttpClient/HttpResponse.php
@@ -36,7 +36,7 @@ public function __construct(string $url, int $statusCode, ?string $body, array $
         $this->url = $url;
         $this->statusCode = $statusCode;
         $this->body = $body;
-        $this->headers = $headers;
+        $this->headers = Utils::getFlatResponseHeaders($headers);
         $this->execTime = $execTime;
     }
 

diff --git a/src/Crawler/Utils.php b/src/Crawler/Utils.php
@@ -1317,4 +1317,21 @@ public static function isAssetByContentType(string $contentType): bool
         return $result;
     }
 
+    /**
+     * Get flat response headers (all values are literals, not arrays)
+     * @param array $headers
+     * @return array
+     */
+    public static function getFlatResponseHeaders(array $headers): array
+    {
+        $result = [];
+        foreach ($headers as $key => $value) {
+            if (is_array($value)) {
+                $value = implode(', ', $value);
+            }
+            $result[$key] = $value;
+        }
+        return $result;
+    }
+
 }