Skip to content

fix a performance regression from mauricio #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oshai opened this issue Sep 17, 2018 · 2 comments
Closed

fix a performance regression from mauricio #15

oshai opened this issue Sep 17, 2018 · 2 comments

Comments

@oshai
Copy link
Contributor

oshai commented Sep 17, 2018 •
edited
Loading

commit:
mauricio/postgresql-async@90e4194
was broken for the performance of Postgres. This was introduced in version 0.2.19
relevant issues:
mauricio/postgresql-async#164
mauricio/postgresql-async#169
mauricio/postgresql-async#231
mauricio/postgresql-async#230
mauricio/postgresql-async#254
mauricio/postgresql-async#179
mauricio/postgresql-async#212
mauricio/postgresql-async#241
oshai pushed a commit that referenced this issue Sep 17, 2018
Fix #15 - revert a commit in original lib that causes performance deg…
9222e13 
…radation
@oshai oshai closed this as completed in 3a868dd Sep 17, 2018
@oshai
Copy link
Contributor Author

oshai commented Sep 17, 2018

fix in version 0.8.30

@oshai
Copy link
Contributor Author

oshai commented Sep 17, 2018 •
edited
Loading

more details here: https://medium.com/@OhadShai/sometimes-a-small-bug-fix-can-lead-to-an-avalanche-f6ded2ecf53d

This was referenced Sep 17, 2018
Merged
Closed
Open
Open
Closed
Open
Open
Open
oshai added a commit that referenced this issue Nov 27, 2021
@oshai
debug #15
3e7f428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oshai