Skip to content

Add support for unix domain socket #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oshai opened this issue Dec 22, 2019 · 9 comments
Closed

Add support for unix domain socket #175

oshai opened this issue Dec 22, 2019 · 9 comments

Comments

@oshai
Copy link
Contributor

oshai commented Dec 22, 2019

This will allow to connect to databases that requires unix socket connection like Google Cloud SQL.

@oshai
Copy link
Contributor Author

oshai commented Dec 23, 2019

see also this issue: spring-projects/spring-data-r2dbc#192

@andy-yx-chen
Copy link
Contributor

I created a PR #176 for this, however don't know how to update the tests to try the new change, if you happen to know how to do it quickly maybe you can add some tests

@oshai
Copy link
Contributor Author

oshai commented Jan 3, 2020

@andy-yx-chen
Copy link
Contributor

Thanks, will work on it tomorrow

@oshai
Copy link
Contributor Author

oshai commented Feb 19, 2020

Any update on this issue?

@github-actions
Copy link

Stale issue message

@oshai
Copy link
Contributor Author

oshai commented Oct 6, 2022

I am continuing the work on this in #319 so reopened the issue.
Thanks @andy-yx-chen and @czp3009 for previous impl (that was not yet merge but part of the current effort) in #176 and #285.

In the api side the current PR adds socketPath to Configuration. I am thinking if this is the most clear approach as in this case host + port are redundant.
Also the current impl fallback to host port in case of some problems (when fallback to nio) and maybe this should be made more explicit.

Lastly, the current PR does not have Postgres tests in case someone wants to contribute that. Otherwise the current PR will be merged without integration test for postgres (which is relatively minor part of the current change, but require setup effort).

This was referenced Oct 7, 2022
@oshai
Copy link
Contributor Author

oshai commented Oct 11, 2022

Implemented in 2.1.6. Thanks @andy-yx-chen and @czp3009!

@oshai oshai closed this as completed Oct 11, 2022
@andy-yx-chen
Copy link
Contributor

Implemented in 2.1.6. Thanks @andy-yx-chen and @czp3009!

Thanks, this has been quite some time, it's great to see this is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants