change the default utf8 encoding #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to this post https://mathiasbynens.be/notes/mysql-utf8mb4 the default utf8 in mysql do not exactly match utf8 standard (3 vs 4 bytes) Since it maps to the same charset in Java It sounds like the reasonable thing to do is to change the used protocol from 83 to 224 (utf8mb4_unicode_ci) I added a flag to allow overriding it `-DjasyncMysqlUTF8Collation=83` To put in back in the old legacy behaviour for example if using mysql server < 5.5.3. Added also tests for this.
|
@swordfeng - would like to get your opinion about this change. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=========================================
Coverage 78.94% 78.94%
Complexity 1011 1011
=========================================
Files 258 258
Lines 3662 3662
Branches 487 487
=========================================
Hits 2891 2891
Misses 531 531
Partials 240 240
Continue to review full report at Codecov.
|
|
@oshai Thank you! It looks good to me. Maybe we could add that flag to the document in case someone is using a version of MySQL released 9 years ago. |
|
released in 0.9.50 and add a wiki here: https://github.com/jasync-sql/jasync-sql/wiki/Supported-Encoding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to this post https://mathiasbynens.be/notes/mysql-utf8mb4
the default utf8 in mysql do not exactly match utf8 standard (3 vs 4 bytes)
Since it maps to the same charset in Java
It sounds like the reasonable thing to do is to change the used protocol
from 83 to 224 (utf8mb4_unicode_ci)
I added a flag to allow overriding it
-DjasyncMysqlUTF8Collation=83To put in back in the old legacy behaviour
for example if using mysql server < 5.5.3.
Added also tests for this.
This PR, is a fix for the issue raised here: vert-x3/vertx-mysql-postgresql-client#149