fix: parsing unified diff chunk headers #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex matching chunk headers does not account for diffs generated with --show-function-line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex matching chunk headers does not account for unified diffs generated with
--show-function-line(with GNU diffutils for example)Currently this library parses only the following chunk header:
@@ -571,6 +571,12 @@But this is also valid:
@@ -571,6 +571,12 @@ .method public constructor <init>(LandroThis also created a very odd error far down the call stack of this method call when
old_lnandnew_lnare both equal to0as a result of failing to parse the chunk headers.java-diff-utils/java-diff-utils/src/main/java/com/github/difflib/UnifiedDiffUtils.java
Lines 92 to 93 in 0f8365b