Skip to content

fixes #89 to get exact add/remove lines' positions #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

HuGanghui
Copy link
Contributor

fixes #89 to get exact add/remove lines' positions

Copy link
Collaborator

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it looks good. Could you please add some tests for these new additions?

@HuGanghui
Copy link
Contributor Author

@wumpz ok, I will add some tests

@HuGanghui
Copy link
Contributor Author

@wumpz I have added tests, please review

Copy link
Collaborator

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@wumpz wumpz merged commit f0f5d24 into java-diff-utils:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to get exact changed lines when using UnifiedDiffUtils.parseUnifiedDiff
2 participants