Skip to content

Extra folder housekeeping #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kubamarchwicki
Copy link
Contributor

As the prerequisite to scrapping Groovy from the project (and moving it to a sparate project) I did some housekeeping in the extra/ folder. That inncluded:

  • Proper naming in project description - as in the main project
  • Ignoring a test that probably never worked

Proper naming - as in the main project
Ignoreing a test that probably never worked
import org.junit.runner.RunWith;

/**
* @author Guillaume Scheibel <guillaume.scheibel@gmail.com>
*/
@RunWith(Arquillian.class)
@Ignore("This test is probably a sad panda; never been successful sad panda.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of keeping it then?

@bartoszmajsak
Copy link
Contributor

👍 if only Travis accepts we can merge it. Thanks Kuba!

@arun-gupta
Copy link
Contributor

No response from @kubamarchwicki and so closing the PR.

@arun-gupta arun-gupta closed this Jul 2, 2015
@kubamarchwicki
Copy link
Contributor Author

@arun-gupta if this work on your machine can you please provide additional README documentation that nosql datastore is required and how to setup. Otherwise, the example is pretty meaningless for a novice user.

Additionally, the commit 08eb6a4 was including some housekeeping in twitter search dependencies. Those could have been merged - otherwise the build is failing. The https://github.com/arun-gupta/twitter-api is a non-maven dependency and have to be provided either through system path of through jitpack.

@arun-gupta
Copy link
Contributor

Lets remove the project from the build and it can be included back when the instructions are updated. Removing the files does not seem right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants