Skip to content

Branch arquillian #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2013
Merged

Branch arquillian #53

merged 4 commits into from
Nov 4, 2013

Conversation

cirix
Copy link
Contributor

@cirix cirix commented Nov 1, 2013

Hi Arun,

this is the first pull request so that you can check that we are on the right path. In this pull request you will find the necessary changes on the pom.xml file of the javaee7-samples parent project which contains the necessary changes for the Arquillian to be configured for all the subprojects and also necessary changes in order to be able to use wildfly with full profile using arquillian container support. The latter may set the cargo maven plugin as not mandatory anymore since most of the appservers are already supported by arquillian. Currently there is only one problem with an exception in the test, I found that it was reported as bug but they say is solved. I work on that. The tricky part was the configuration.

regards
Nick

@arun-gupta
Copy link
Contributor

I didn't know you were looking at websocket/binary for your first test case. I changed it to be more comprehensive earlier today. Can you send another PR taking new files into account ?

@cirix
Copy link
Contributor Author

cirix commented Nov 2, 2013

Yes...I took it alphabetically. I will. With the changes in the pom files
is it ok or should I add comments? You prefer I focus ob specific part of
websockets first? Just woke up...I hope my commits aren't jet lagged :-)
On 2 Nov 2013 07:10, "Arun Gupta" notifications@github.com wrote:

I didn't know you were looking at websocket/binary for your first test
case. I changed it to be more comprehensive earlier today. Can you send
another PR taking new files into account ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/53#issuecomment-27616599
.

@cirix
Copy link
Contributor Author

cirix commented Nov 2, 2013

I have merge the changes you did...and yup more comprehensive coverage there. When you have the time send any comments you may have, good or bad are equally accepted.

arun-gupta added a commit that referenced this pull request Nov 4, 2013
Initial support for Arquilian by Nick
@arun-gupta arun-gupta merged commit 14f3215 into javaee-samples:master Nov 4, 2013
@arun-gupta
Copy link
Contributor

Lets keep the indentation to 4 spaces to be consistent across the workspace.

@cirix
Copy link
Contributor Author

cirix commented Nov 4, 2013

Ok, that's probably coming from my Eclipse. The problem I faced downloading
the new Eclipse is that even if the naming of appserver is different by the
structure is the same. Wildfly isn't yet supported by Netbeans. I tried the
last 7.4 something. I am to long in the Eclipse...:) I will update my conf
files. If you have any config profile you like and you are using in
Netbeans I can import it in Eclipse. Currently I am using Eclipse Kepler.
You will be switching to Eclipse of stick with Netbeans?Take into account
that if you install the m2eclipse plugin for Eclipse you can have
multihierarchical projects in Eclipse also.On top support is added to that
by the jboss maven tools plugin. The only thing to take under
consideration, is that if you enable all the available jboss studio tools
in a custom eclipse...the damn thing becomes really slow...and now you can
unleash your fire about Eclipse :). Have a safe fly.Talk tomorrow again.

regards
\n\m

On Mon, Nov 4, 2013 at 3:10 PM, Arun Gupta notifications@github.com wrote:

Lets keep the indentation to 4 spaces to be consistent across the
workspace.


Reply to this email directly or view it on GitHubhttps://github.com//pull/53#issuecomment-27687000
.

\n\m
"camel is a horse made up in a laboratory"

@arun-gupta
Copy link
Contributor

NetBeans lack of support for WildFly is really making me think about my loyalty to NetBeans. Eclipse with WildFly support is definitely high on my list, been also planning to try IntelliJ as well.

So you think Eclipse Kepler + m2eclipse is decent ? Any subset of JBoss Tools that is more useful than the full set ?

@jaenswart
Copy link

Arun,  I use JBDS with the integration tooling installed and it works great......but I've always hinted at moving towards intellij as  platform for jbds.  Intellij really rocks but for Wildfly jbds is tops

Sent from Samsung Mobile

-------- Original message --------
From: Arun Gupta notifications@github.com
Date:04/11/2013 16:28 (GMT+02:00)
To: arun-gupta/javaee7-samples javaee7-samples@noreply.github.com
Subject: Re: [javaee7-samples] Branch arquillian (#53)

NetBeans lack of support for WildFly is really making me think about my loyalty to NetBeans. Eclipse with WildFly support is definitely high on my list, been also planning to try IntelliJ as well.

So you think Eclipse Kepler + m2eclipse is decent ? Any subset of JBoss Tools that is more useful than the full set ?


Reply to this email directly or view it on GitHub.

jGauravGupta pushed a commit to jGauravGupta/javaee7-samples that referenced this pull request Jul 30, 2020
CUSTCOM-253 Adapt AJAX test for script reloading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants