Fix servlet/http2 when using latest Oracle JDK versions #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems when using Oracle, default jdk 1.8 isn't detected |
|
This is really weird. Perhaps add profiles for the other versions of Oracle JDK 8 between 1.8.0_152 and 1.8.0_201, per https://github.com/jetty-project/jetty-alpn/blob/master/docs/version_mapping.properties? |
c5b1507 to
e35a152
Compare
|
@Ladicek I added them in order to be consistent. Thanks for suggestion |
|
@juangon I don't think what you added is correct. JDKs from 1.8.0_161 to 1.8.0_181 use 8.1.12.v20180117, per the file I linked above. |
e35a152 to
b348ed6
Compare
|
@Ladicek thanks a lot. I took a brief look and thought they were all the same numbers. Thankfully I am not an accountant :-) |
|
Great, thanks :-) LGTM now. |
arjantijms
approved these changes
Feb 28, 2019
|
Cool, thx again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @arjantijms . We detected this issue thanks to our test matrix and affected Payara too. Thanks!