Node transformers topological sort #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2019 19:46
…Keys` option * Internal `TransformersRunner` rework to support topological sort of node transformers
|
TODO: tests for LevelledTopologicalSorter |
|
Cool feature, I'll could review it only a one week later, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node transformers topological sort
Ability to define dependencies on other nodes inside the same transformation stage.
Node transformers will split into groups based on these relations.
AST traversal will traverse the AST for each group, so, this is like sub-stages.
This mechanism is required, because when some part of the AST-tree was manually added inside the transformer,
estraversewon't traverse this part of the AST in the current traversal.As a result - the next transformers inside the same transformation stage won't transform the newly added part of the AST.
TODO: