Skip to content

Object to primitive conversion #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 26, 2021
Merged

Object to primitive conversion #177

merged 8 commits into from
Nov 26, 2021

Conversation

mahdiHash
Copy link
Contributor

Please review and comment/commit if anything is wrong

@mahdiHash
Translate a part of article
7cbd081 
Lines 12 and 14 need more attention.
@mahdiHash
Translate a part of article
595d69a 
This part (conversion rules) needs more attention.
It was complicated.
@mahdiHash
Translate a part of article
1fa4aa0
@mahdiHash
Translate a part of article
29d0b5c 
Line 139 needs more attention
@mahdiHash
Translate a part of article
267f846
@mahdiHash
Translate article
8de3bf3 
Lines 253, 275 and 277 need more attention.
@mahdiHash
Merge branch 'master' of https://github.com/mahdihashemi14/fa.javascr…
d8a6677 
…ipt.info
@javascript-translate-bot javascript-translate-bot requested a review from a team November 25, 2021 11:23
@javascript-translate-bot javascript-translate-bot mentioned this pull request Nov 25, 2021
Open
mahdiHash
mahdiHash commented Nov 25, 2021
View reviewed changes
mahdiHash
mahdiHash commented Nov 25, 2021
View reviewed changes
mahdiHash
mahdiHash commented Nov 25, 2021
View reviewed changes
@mahdiHash mahdiHash marked this pull request as ready for review November 25, 2021 11:26
mahdyar
mahdyar approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestion(s).

mahdyar
mahdyar requested changes Nov 25, 2021
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestion(s).

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash @mahdyar
Apply suggestions from code review
2a31b9f 
Co-authored-by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash
Copy link
Contributor Author

mahdiHash commented Nov 25, 2021 •
edited
Loading

Thank you @mahdyar
I also have a question: do you think "جزء" is a good translation for "hint"? For example in line 35.

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team November 25, 2021 17:45
mahdyar
mahdyar approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mahdyar
I also have a question: do you think "جزء" is a good translation for "hint"? For example in line 35.
/done

Yes, that LGTM.
Thank you, @mahdiHashemi14!

@mahdyar mahdyar merged commit 0e66dd1 into javascript-tutorial:master Nov 26, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees
No one assigned
Labels
needs +1 review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahdiHash @javascript-translate-bot @mahdyar