Skip to content

Eval: run a code string #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

Eval: run a code string #159

wants to merge 35 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ odsantos
✅ HakaCode
❌ Ashura

Ashura seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@odsantos
Copy link
Contributor

Hi @AshuraDev would you please resolve the conflicts or inform if you're unavailable to continue with this PR? Thank you.

@ghost
Copy link
Author

ghost commented Jan 31, 2021

Olá @AshuraDev, poderia resolver os conflitos ou informar se não estiver disponível para continuar com este PR? Obrigado.

I resolved conflicts :)

odsantos
odsantos requested changes May 19, 2021
View reviewed changes
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshuraDev here is a review.
Would you please let me know of something you might disagree?
Thank you,
Osvaldo.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ashuradev and others added 7 commits May 19, 2021 11:47
@odsantos
Update 1-js/99-js-misc/02-eval/1-eval-calculator/task.md
b3ebc0d 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
dea981d 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
627898f 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
5589be2 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
47c9e89 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
9385f54 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
80feedb 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
ashuradev and others added 11 commits May 19, 2021 11:52
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
e1cca32 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
980f579 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
75371f9 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
32ce693 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
05dd276 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
3585e5a 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
7680f57 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
cf4d973 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
26ffb20 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
1f002e2 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@odsantos
Update 1-js/99-js-misc/02-eval/article.md
3cc8dab 
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@ghost
Copy link
Author

ghost commented May 19, 2021

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team May 19, 2021 15:05
odsantos added 2 commits May 19, 2021 16:43
@odsantos
Update article.md
2c95a88 
Minor translation changes.
@odsantos
Update article.md
2bf304a 
Put back a variable name.
odsantos
odsantos approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshuraDev ,

I hope you don't mind I added three minor changes I believe I forgot to ask.
I suppose we still need a second reviewer.

Thank you very much.

@ghost
Copy link
Author

ghost commented May 20, 2021

Okay :)

eujuliu
eujuliu approved these changes Jun 18, 2021 •
edited
Loading
View reviewed changes
@odsantos
Copy link
Contributor

@jjuliomarttins , thank you.

@odsantos
Copy link
Contributor

Hello @luizclr , @adriavieira314 , @kiniggit , @Mr-Saxobeat , please this PR #159 needs a second review. Thank you.

@odsantos
Copy link
Contributor

Hello @luizclr , @jonnathan-ls , @Mr-Saxobeat , this PR #159 needs a second review. Thank you.

@odsantos
Copy link
Contributor

The account was deleted.
Much appreciated for all done.
I'm taking this work and creating a new PR.
Best wishes.

@odsantos odsantos closed this Jan 20, 2023
@odsantos odsantos mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CLAassistant @odsantos @javascript-translate-bot @eujuliu @HakaCode