Skip to content

Comments #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 29, 2020
Merged

Conversation

alexgalkin
Copy link
Contributor

Translation of the "Comments" section.

Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small corrections


```js
function showPrimes(n) {
nextPrime:
for (let i = 2; i < n; i++) {

*!*
// check if i is a prime number
// перевірка чи є i простим числом
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// перевірка чи є i простим числом
// перевірка чи є 'i' простим числом

}
```
Наприклад:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space.
It's better to add this one to English version as PR and this will be merged into Ukrainian if approved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created separate PR javascript-tutorial/en.javascript.info#1780 for this in English version

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

alexgalkin and others added 8 commits February 29, 2020 22:48
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team February 29, 2020 21:00
@alexgalkin alexgalkin requested review from tarasyyyk and removed request for a team February 29, 2020 21:00
@tarasyyyk tarasyyyk merged commit aabd08b into javascript-tutorial:master Feb 29, 2020
@tarasyyyk tarasyyyk changed the title Translation of "Comments" section Comments Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants