Skip to content

Support for single-column searching #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

tombenner
Copy link

Thanks for making this; it's been very useful!

I noticed that there wasn't support for single-column searching, which I needed, so I've added it in.

To save you from digging through the docs: fnFilter optionally takes a second argument that specifies the column which the search should target (e.g. myTable.fnFilter('my search', 3)), and this adds support for that.

@tombenner
Copy link
Author

Just a quick note that I've added support for database-agnostic case-insensitive searching, too. The previous implementation used LIKE, which is case-sensitive on Postgres and probably isn't the expected behavior for most use cases.

@JoelQ
Copy link
Contributor

JoelQ commented May 11, 2013

Thank you for for contributing to the project! Unfortunately, I am no longer maintaining it. If you are interested in taking over the project, please let me know.

@tombenner
Copy link
Author

Actually, my company, @socialpandas, would indeed be interested in taking over the project. We depend on it as a core piece of some of our internal architecture, so we'd be very happy to maintain it. If this sounds like it'd make sense, let me know!

@antillas21
Copy link
Collaborator

Hi @tombenner,

I just became the maintainer for this gem.

I would like to close this PR and invite to check the changes we have in store for this project (to be released soon).

You'd be happy to know that some of these changes are inspired in your fork from this gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants