Skip to content

Fixed where clause being built when search is empty string #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2014

Conversation

e-fisher
Copy link
Contributor

Fixed where clause being built when search is empty string, which caused records with nil values to be excluded

antillas21 added a commit that referenced this pull request Jun 18, 2014
Fixed where clause being built when search is empty string
@antillas21 antillas21 merged commit a19a9db into jbox-web:master Jun 18, 2014
@antillas21
Copy link
Collaborator

Thanks @e-fisher for spotting this 😄

@antillas21
Copy link
Collaborator

@e-fisher a new release is up. This is the changelog for this release.

Thank you for your contribution.

@e-fisher
Copy link
Contributor Author

No problem! It's a nice extension, started working with rails not so long
time ago and was looking for a simple table with ajax sorting / pagination
solution and it fit me best. Keep up! :)

On Wed, Jun 18, 2014 at 5:46 PM, Antonio Antillon notifications@github.com
wrote:

Thanks @e-fisher https://github.com/e-fisher for spotting this [image:
😄]


Reply to this email directly or view it on GitHub
#22 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants