Fix count method to work with select statement for Rails 4.1 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antillas21
added a commit
that referenced
this pull request
Jul 31, 2014
Fix count method to work with select statement for Rails 4.1
|
Thanks @mitchej123 for spotting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in Rails 4.1 prevents .count from working when you do something like
User.select("id, name").countwhich would generate the SQL:SELECT COUNT(id, name) FROM users;which gives an error.One work around I found was instead calling
User.select("id, name").count(:all)which generates the SQLSELECT COUNT(*) FROM users;which works.