[JENKINS-28319] encrypt the client secret #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks OK to me +2. I'll leave it open a bit for other interested eyeballs. I'd say this supersedes PR #50 and fixes [JENKINS-28319]. Please amend your commit message to include |
|
Amended the commit message. Thanks @samrocketman. |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
@samrocketman - Just checking on the status of this. Don't want it to get stale. |
|
Ah, thanks for the reminder. I'll focus on it this weekend (or evenings before the weekend when I get time). |
|
I have tested this. Works well. |
samrocketman
added a commit
that referenced
this pull request
Apr 29, 2016
|
Thank you sir. |
|
I plan to release this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encrypts the client secret and uses
HudsonTestCaseto get around mocking outSecret.