JENKINS-45726 Corrected a connectivity error on auth with proxy #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrocketman
requested changes
Jul 29, 2017
| @@ -185,14 +193,43 @@ public String getGithubServer() { | |||
|
|
|||
| public GitHub getGitHub() throws IOException { | |||
| if (this.gh == null) { | |||
|
|
|||
| String host; | |||
There was a problem hiding this comment.
Mixing tabs and spaces. Please convert all tabs to four spaces.
| throw new IOException("Invalid GitHub API URL: " + this.githubServer, e); | ||
| } | ||
|
|
||
| OkHttpClient client = new OkHttpClient().setProxy(getProxy(host)); |
samrocketman
approved these changes
Aug 4, 2017
|
@esteveblanch Apologies for taking a while to get around this. I'm going to test this right now ensuring it doesn't affect existing plugin configurations and upgrades. Once, I verify it upgrades smoothly I'll immediately merge and release. If I find any issues in my testing I will post my feedback here. |
samrocketman
added a commit
that referenced
this pull request
Oct 1, 2017
error on auth with proxy See also: * [JENKINS-45726][JENKINS-45726] [JENKINS-45726]: https://issues.jenkins-ci.org/browse/JENKINS-45726
|
See also #86. GitHub Authentication Plugin 0.28 has been released to the Jenkins Update Center. It will become available roughly within 8 hours from the time of this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the GithubAuthenticationToken the GitHub instance was created without the proxy information.
That causes authentication errors when there's a network proxy.