Summary

Overall, your recommended change here is a huge performance improvement for the github-oauth plugin. You also resolve the issue you set out to solve. I added an extra irrelevant test, it does not block merging this.

Test summary

• ✅ User pages load faster [SUCCESS]
• ✅ Jenkins CLI returns authorities via Jenkins API token [SUCCESS]
• ✅ Call REST API using Jenkins API token [SUCCESS]
• ❌ Jenkins CLI returns authorities via SSH auth [FAILED] (non-blocking test just for fun)

User pages load faster [SUCCESS]

User pages load really fast now! This is a huge improvement.

http://localhost:8080/user/samrocketman/ used to take a whole minute for me to wait around until the page loaded. Your change does a great job improving the performance on this page specifically.

Jenkins CLI returns authorities via Jenkins API token [SUCCESS]

Jenkins CLI with Jenkins API token was successfully tested.

java -jar jenkins-cli.jar -s http://localhost:8080/ -http -auth samrocketman:2f94a910ad75c684b27885e8e5d7f2c1 -noKeyAuth who-am-i

Call REST API using Jenkins API token [SUCCESS]

The following two API calls succeeded. Both were restricted by GitHub organizations and not directly specifying the user in the project-based matrix authorization strategy.

curl --user samrocketman:2f94a910ad75c684b27885e8e5d7f2c1 http://localhost:8080/user/samrocketman/api/json?pretty=true

curl --user samrocketman:2f94a910ad75c684b27885e8e5d7f2c1 http://localhost:8080/job/test/job/test2/api/json?pretty=true

Jenkins CLI returns authorities via SSH auth [FAILED]

This bug is tracked by JENKINS-48423.

Jenkins CLI with SSH private key was not successfully tested. That doesn't block merging this. It just surfaces a new issue. I filed this new issue under

java -jar jenkins-cli.jar -s http://localhost:8080/ -ssh -user samrocketman who-am-i