Skip to content

FIX keep on importing distutils for now #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Feb 26, 2022

Temporary mitigation for scikit-learn/scikit-learn#22614 .

To be removed 6 months or so after the release of scikit-learn 1.1.

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #1277 (33027b7) into master (36c0288) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
+ Coverage   93.80%   93.83%   +0.02%     
==========================================
  Files          50       50              
  Lines        7267     7268       +1     
==========================================
+ Hits         6817     6820       +3     
+ Misses        450      448       -2     
Impacted Files Coverage Δ
joblib/backports.py 69.69% <100.00%> (+0.30%) ⬆️
joblib/_parallel_backends.py 92.27% <0.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c0288...33027b7. Read the comment docs.

@ogrisel ogrisel merged commit 3c1c2dd into joblib:master Feb 26, 2022
@ogrisel ogrisel deleted the import-distutils branch February 26, 2022 17:08
@PeterJCLaw
Copy link
Contributor

It looks like scikit-learn 1.1 was released in May 2022; it's now 6 months later. Are you open to a PR which drops the distutils import?

@tomMoral
Copy link
Contributor

yes, that would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants