Fix authentication issue in Docker container #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be nice if you can setup dependabot for the actions (in a separate PR) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #260.
It also bumps all workout actions to their latest versions and adds info about how to use the Docker version to the README.
Quick background:
The
checkoutaction would persist a server-to-server GitHub token in the container which caused authentication to fail for the end user because the container would use the sts token instead of the provided personal or fine token.The fix was to add
persist-credentials: falseto the checkout workflow.This works for me now - would be happy for someone else to confirm it's working for them, too!