Skip to content

Throw a more helpful error if Buffer is undefined in decoder #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

Throw a more helpful error if Buffer is undefined in decoder #93

merged 1 commit into from
Jul 15, 2021

Conversation

DT-1236
Copy link
Contributor

@DT-1236 DT-1236 commented Jun 10, 2021

Hopefully this will help anyone else that tries to decode a jpeg in a non-Node environment such as react-native, avoiding a repeat of #92

patrickhulce
patrickhulce approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DT-1236 !

@patrickhulce patrickhulce merged commit b58cc11 into jpeg-js:master Jul 15, 2021
@patrickhulce patrickhulce mentioned this pull request Jul 15, 2021
Closed
zed-0xff pushed a commit to zed-0xff/jpeg-js that referenced this pull request Feb 24, 2023
@DT-1236
fix(decoder): rethrow a more helpful error if Buffer is undefined (jp…
51113b4 
…eg-js#93)
@ASISBusiness ASISBusiness mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DT-1236 @patrickhulce