Skip to content

Gruntfile: Fix the need for manual npm install before prepare #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Gruntfile: Fix the need for manual npm install before prepare #263

wants to merge 1 commit into from

Conversation

xbili
Copy link
Contributor

@xbili xbili commented Mar 7, 2015

The callback and next arguments placed in the wrong order, so npm install doesn't get run in tmp/api.jquery.com most of the time.

This fixes the previous issue I had here as well.

@xbili
Gruntfile: Fix the need for manual npm install before prepare
90b979e 
Error caused by a faulty if-else statement.
@xbili
Copy link
Contributor Author

xbili commented Mar 7, 2015

Much apologies, I believe my git config wasn't set up properly. I'll reopen this.

@xbili xbili closed this Mar 7, 2015
@xbili xbili deleted the 262-fix-manual-npm-install branch March 7, 2015 14:34
@xbili xbili mentioned this pull request Mar 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xbili @jquerybot