Skip to content

Commit

Permalink
Core: revert addition of createHTMLDocument. Thanks, Safari 8.
Browse files Browse the repository at this point in the history
- Safari 8 has issues when the HTML string contains forms.
  Closing tags are not respected.
  • Loading branch information
timmywil committed Dec 9, 2014
1 parent 4ab7431 commit b779831
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
4 changes: 1 addition & 3 deletions src/core/parseHTML.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ jQuery.parseHTML = function( data, context, keepScripts ) {
keepScripts = context;
context = false;
}
// document.implementation stops scripts or inline event handlers from
// being executed immediately
context = context || document.implementation.createHTMLDocument( "" );
context = context || document;

var parsed = rsingleTag.exec( data ),
scripts = !keepScripts && [];
Expand Down
14 changes: 0 additions & 14 deletions test/unit/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -1370,20 +1370,6 @@ test("jQuery.parseHTML", function() {
ok( jQuery.parseHTML("<#if><tr><p>This is a test.</p></tr><#/if>") || true, "Garbage input should not cause error" );
});

asyncTest("jQuery.parseHTML", function() {
expect ( 1 );

Globals.register("parseHTMLError");

jQuery.globalEval("parseHTMLError = false;");
jQuery.parseHTML( "<img src=x onerror='parseHTMLError = true'>" );

window.setTimeout(function() {
start();
equal( window.parseHTMLError, false, "onerror eventhandler has not been called." );
}, 2000);
});

test("jQuery.parseJSON", function() {
expect( 20 );

Expand Down

0 comments on commit b779831

Please sign in to comment.