Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse support.ownLast #2406

Closed
mgol opened this issue Jun 17, 2015 · 8 comments
Closed

Reverse support.ownLast #2406

mgol opened this issue Jun 17, 2015 · 8 comments
Assignees
@mgol
Labels
1.x-only wontfix

Comments

@mgol
Copy link
Member

mgol commented Jun 17, 2015

jQuery.support.ownLast is the only support test that's supposed to be false when it succeeds. It's confusing, we should reverse its value.
@mgol mgol added the 1.x-only label Jun 17, 2015
@mgol mgol added this to the 3.0.0 milestone Jun 17, 2015
@mgol mgol self-assigned this Jun 17, 2015
@mgol mgol mentioned this issue Jun 17, 2015
Closed
mgol added a commit to mgol/jquery that referenced this issue Jun 17, 2015
@mgol
Core: Change support.ownLast to support.ownFirst
91dfaf4 
jQuery.support.ownLast was the only support test that was supposed
to be false when it succeeded. It was confusing.

Fixes jquerygh-2406
@mgol mgol mentioned this issue Jun 17, 2015
Closed
@mgol
Copy link
Member Author

mgol commented Jun 17, 2015

PR: #2408

mgol added a commit that referenced this issue Jun 22, 2015
@mgol
Core: Change support.ownLast to support.ownFirst
453738a 
jQuery.support.ownLast was the only support test that was supposed
to be false when it succeeded. It was confusing.

Fixes gh-2406
Closes gh-2408
@mgol
Copy link
Member Author

mgol commented Jun 22, 2015

Closed via #2408.

@mgol mgol closed this as completed Jun 22, 2015
@mgol mgol removed this from the 3.0.0 milestone Nov 5, 2015
@mgol
Copy link
Member Author

mgol commented Nov 5, 2015

Clearing the milestone as we're not releasing compat after all and this change won't be applicable to code that has to support IE6/7.

@markelog markelog removed the wontfix label Dec 22, 2015
@markelog
Copy link
Member

@mzgol fyi, since we are releasing another compat, wonfix label removed

@mgol
Copy link
Member Author

mgol commented Dec 22, 2015

Not compat, but regular 1.x. I added wontfix here because this issue doesn't matter for code soon to be dead. If it's included in your 1.12-stable branch, though, then removing wontfix is fine.

@mgol
Copy link
Member Author

mgol commented Dec 22, 2015

But, if you're removing the wontfix label, please remember to open the issue and assign the proper milestone...

@markelog
Copy link
Member

Not compat, but regular 1.x.

It is just a name change, so for me, it is a same thing.

But, if you're removing the wontfix label, please remember to open the issue and assign the proper milestone...

should be done in general

@markelog
Copy link
Member

Not compat, but regular 1.x.

Apparently, for the team too, since we still use 1.x label

@mgol mgol added the wontfix label Jan 27, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
1.x-only wontfix
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markelog @mgol