Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery.when doesn't recognize solitary thenables #2546

Closed
gibson042 opened this issue Aug 19, 2015 · 1 comment · Fixed by #2707
Closed

jQuery.when doesn't recognize solitary thenables #2546

gibson042 opened this issue Aug 19, 2015 · 1 comment · Fixed by #2707
Assignees
@timmywil
Labels
Behavior Change Blocker Deferred
Milestone
3.0.0

Comments

@gibson042
Copy link
Member

jQuery.when( a ) does not look for a then method on its argument, which differs from its behavior in longer jQuery.when( a, … ) invocations. It should treat non-Deferred thenables identically in both cases.

http://jsfiddle.net/0r62we79/9/
@gibson042 gibson042 added this to the 3.0.0 milestone Aug 19, 2015
@gibson042 gibson042 mentioned this issue Aug 19, 2015
Closed
@mgol mgol mentioned this issue Aug 19, 2015
Closed
@marcandre
Copy link

And I thought I was going crazy...

var failed = new Promise(function(resolve, reject) { reject('fail!'); });
$.when(failed).then(function(){console.log('Should not be here')});  // Not ok
$.when(failed, failed).then(function(){console.log('Should not be here either')}); // Ok

Currently outputs "Should not be here" to the console.

@marcandre marcandre mentioned this issue Aug 22, 2015
Closed
@timmywil timmywil self-assigned this Nov 9, 2015
timmywil added a commit to timmywil/jquery that referenced this issue Nov 11, 2015
@timmywil
Deferred: syncronize single and multiple target handling in $.when
650e68b 
Fixes jquerygh-2546
Fixes jquerygh-2018
@timmywil timmywil mentioned this issue Nov 11, 2015
Merged
timmywil added a commit to timmywil/jquery that referenced this issue Nov 11, 2015
@timmywil
Deferred: syncronize single and multiple target handling in $.when
334b9ea 
Fixes jquerygh-2546
Fixes jquerygh-2018
timmywil added a commit to timmywil/jquery that referenced this issue Nov 11, 2015
@timmywil
Deferred: syncronize single and multiple target handling in $.when
246d263 
Fixes jquerygh-2546
Fixes jquerygh-2018
timmywil added a commit to timmywil/jquery that referenced this issue Nov 13, 2015
@timmywil
Deferred: syncronize single and multiple target handling in $.when
78b9eac 
Fixes jquerygh-2546
Fixes jquerygh-2018
Close jquerygh-2707
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Behavior Change Blocker Deferred
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Deferred: synchronize single and multiple target handling in $.when timmywil/jquery
5 participants
@marcandre @dmethvin @timmywil @gibson042 @mgol