Skip to content

For 1.8: fixes #12088, Webkit now returning percentages for more getComputedStyle properties #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

For 1.8: fixes #12088, Webkit now returning percentages for more getComputedStyle properties #865

wants to merge 2 commits into from

Conversation

mikesherov
Copy link
Member 

Running "compare_size:files" (compare_size) task
Sizes - compared to master
    256134       (+50)  dist/jquery.js                                         
     92445       (-24)  dist/jquery.min.js                                     
     33180        (-2)  dist/jquery.min.js.gz

@mikesherov
Copy link
Member Author

OK, not really Webkit, but Safari 5.1.7

@dmethvin dmethvin closed this in aa3fabc Jul 23, 2012
@dmethvin
Copy link
Member

Looks like this is causing a fail: http://wnd8.com/grab/a38f28.png

Didn't see this until after the following commit, I guess it was a caching issue but the bisect identified it here.

@mikesherov
Copy link
Member Author

Ok. I'll investigate today.

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@mikesherov @dmethvin
Fix #12088, Safari 5 and more percentages in getComputedStyle
281d9be 
In particular, min-width and max-width are taunting the awesome hack. Closes jquerygh-865.
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesherov @dmethvin