Fix #12350: jQuery.trim should remove BOM #902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // IE doesn't match non-breaking spaces with \s | ||
| rtrim = core_rnotwhite.test("\xA0") ? (/^[\s\xA0]+|[\s\xA0]+$/g) : /^\s+|\s+$/g, | ||
| // Make sure we trim BOM and NBSP (here's looking at you, Safari 5.0 and IE) | ||
| rtrim = core_rnotwhite.test("\uFEFF") ? /^[\s\xA0\uFEFF]+|[\s\xA0\uFEFF]+$/g : /^\s+|\s+$/g, |
There was a problem hiding this comment.
This should work in all supported browsers. Testing against "\xA0\uFEFF" would be more correct technically, but cost 4 bytes gzipped.
Cue someone showing an implementation recognizing BOM but not NBSP...
|
Updated at the behest of my conscience (a.k.a. @jaubourg). There's really no reason to conditionally define |
|
Yeah, this is a lot more direct. |
| @@ -605,7 +605,7 @@ jQuery.extend({ | |||
| }, | |||
|
|
|||
| // Use native String.trim function wherever possible | |||
| trim: core_trim ? | |||
| trim: core_trim && !core_trim.call("\uFEFF\xA0") ? | |||
There was a problem hiding this comment.
@gibson042 this is really nice :)
|
Landed in 9e246dd . |
|
\o/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with Safari 5.0 support!
Sizes - compared to master @ ac043b1