fixes #12313, regression: .height() and .width() no longer fall back to CSS if offsetWidth is undefined. #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to CSS if offsetWidth is undefined.
| @@ -411,7 +411,10 @@ function getWidthOrHeight( elem, name, extra ) { | |||
| valueIsBorderBox = true, | |||
| isBorderBox = jQuery.support.boxSizing && jQuery.css( elem, "boxSizing" ) === "border-box"; | |||
|
|
|||
| if ( val <= 0 ) { | |||
| // some non-html elements return undefined for offsetWidth, so check for null/undefined | |||
| // svg - https://bugzilla.mozilla.org/show_bug.cgi?id=649285 | |||
There was a problem hiding this comment.
should this be covered by a unit test?
There was a problem hiding this comment.
From the PR description: "I did not include unit tests, however, because those would require us to be testing SVG and MathML, and is not something I'm interested in. I'm interested in fixing this regression and including an explanatory comment. If this means it doesn't get merged, so be it."
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fix" fixes a regression in SVG, which I know we say we "won't fix", but was simple enough and was a regression in 1.8 when I changed an if from
val > 0to a guard clause ofval <= 0, which I thought was the opposite. However, bothundefined > 0andundefined <= 0are false :-|I did not include unit tests, however, because those would require us to be testing SVG and MathML, and is not something I'm interested in. I'm interested in fixing this regression and including an explanatory comment. If this means it doesn't get merged, so be it.