Fixed more universal issue than ticket 4467 #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle is grabbed and dragged from anywhere other than absolute center. Fixed #4467 - Poor UX, slider should act like a normal scrollbar. This is universal and not specific to IE and FF as ticket states.
|
Thanks, landed in 0c3e56d. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scott (Gonzalez),
Sorry, I figured out the right way to submit a fix now.
From the jqueryUI demo
http://jqueryui.com/demos/slider/#side-scroll
If you click the handle anywhere but the center, the handle will snap it's center to where your mouse is. And, starting from that point, when you drag, the slider will pop back to where you had initially grabbed the handle. That causes the slider and handle to jump a couple of times in quick succession.
My fix prevents sliding from occurring on mousedown when the mouse is over the handle but still allows for sliding on click in the handle's track and on drag.