Demo: Fix captcha and marketo demo #1103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,5 +31,3 @@ | |||
|
|
|||
| // Output the image as a png | |||
| imagepng($image); | |||
|
|
|||
| ?> | |||
There was a problem hiding this comment.
You removed the closing PHP tag
There was a problem hiding this comment.
Its a good practice to strip the php ending tags. Those are optional and sometimes cause problems when they are followed by whitespace chars
There was a problem hiding this comment.
Yes. Closing PHP tags increases the chance for hidden whitespace and other plain text characters making it's way into the output, which is hazardous if emitting image data to the stream.
There was a problem hiding this comment.
Ah, beat me to the punch, @staabm !
There was a problem hiding this comment.
OK, I know nothing about PHP so I'll trust you guys 😉
|
Thanks! Resolved the conflict with the changes from #1104 and fixed the captcha-reloading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captcha demo did not link to the correct folder for jquery-validate.js, and also had an unnecessary .htaccess allowing execution of jpg files as php (which is needless since there are no jpg in that folder). This is a very minor security risk, but probably not one that needs to be kept around.
Fixed content type of image being incorrectly reported as text/html, which caused browser warnings.
Marketo demo also had a broken link to jquery-validate.js